Fix and modernize Waxman leak sensor quirk#4772
Draft
TheJulianJES wants to merge 6 commits intozigpy:devfrom
Draft
Fix and modernize Waxman leak sensor quirk#4772TheJulianJES wants to merge 6 commits intozigpy:devfrom
TheJulianJES wants to merge 6 commits intozigpy:devfrom
Conversation
Use ` in Waxman leak sensor quirk
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #4772 +/- ##
==========================================
+ Coverage 92.32% 92.42% +0.10%
==========================================
Files 371 371
Lines 12190 12170 -20
==========================================
- Hits 11254 11248 -6
+ Misses 936 922 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
puddly
reviewed
Feb 19, 2026
|
|
||
| alerts_notification = foundation.ZCLCommandDef( | ||
| id=WAXMAN_CMDID, | ||
| id=0x0001, |
Contributor
There was a problem hiding this comment.
ZCL command IDs are 8 bit:
Suggested change
| id=0x0001, | |
| id=0x01, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Fixes the IAS Zone type and modernizes the entire Waxman leak sensor quirk.
A test is also added.
Additional information
Noticed during:
LocalDataCluster._DEFAULT_VALUES#4771Device diagnostics
Not available.
Checklist
pre-commitchecks pass / the code has been formatted using Black