Skip to content

Fix and modernize Waxman leak sensor quirk#4772

Draft
TheJulianJES wants to merge 6 commits intozigpy:devfrom
TheJulianJES:tjj/waxman_ias_constant_attributes_fix
Draft

Fix and modernize Waxman leak sensor quirk#4772
TheJulianJES wants to merge 6 commits intozigpy:devfrom
TheJulianJES:tjj/waxman_ias_constant_attributes_fix

Conversation

@TheJulianJES
Copy link
Collaborator

Proposed change

Fixes the IAS Zone type and modernizes the entire Waxman leak sensor quirk.
A test is also added.

Additional information

Noticed during:

Device diagnostics

Not available.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works
  • Device diagnostics data has been attached

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.42%. Comparing base (40b41de) to head (5b952b6).

Files with missing lines Patch % Lines
zhaquirks/waxman/leaksmart.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4772      +/-   ##
==========================================
+ Coverage   92.32%   92.42%   +0.10%     
==========================================
  Files         371      371              
  Lines       12190    12170      -20     
==========================================
- Hits        11254    11248       -6     
+ Misses        936      922      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


alerts_notification = foundation.ZCLCommandDef(
id=WAXMAN_CMDID,
id=0x0001,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ZCL command IDs are 8 bit:

Suggested change
id=0x0001,
id=0x01,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments