Skip to content

Checkin failure #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Checkin failure #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39ac680
Send fast_poll_stop even if checkin doesn't get an answer.
gmsoft-tuxicoman Oct 10, 2024
27a2828
Import traceback.
gmsoft-tuxicoman Oct 10, 2024
498fe22
Apply pre-commit auto fixes
pre-commit-ci[bot] Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions zha/zigbee/cluster_handlers/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from enum import Enum
import functools
import logging
import traceback
from typing import TYPE_CHECKING, Any, Final, ParamSpec, TypedDict

import zigpy.exceptions
Expand Down
12 changes: 9 additions & 3 deletions zha/zigbee/cluster_handlers/general.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,9 +627,15 @@

async def check_in_response(self, tsn: int) -> None:
"""Respond to checkin command."""
await self.checkin_response(True, self.CHECKIN_FAST_POLL_TIMEOUT, tsn=tsn)
if self._endpoint.device.manufacturer_code not in self._IGNORED_MANUFACTURER_ID:
await self.set_long_poll_interval(self.LONG_POLL)
try:
await self.checkin_response(True, self.CHECKIN_FAST_POLL_TIMEOUT, tsn=tsn)
if (
self._endpoint.device.manufacturer_code
not in self._IGNORED_MANUFACTURER_ID
):
await self.set_long_poll_interval(self.LONG_POLL)
except Exception:
self.error(traceback.format_exc())

Check warning on line 638 in zha/zigbee/cluster_handlers/general.py

View check run for this annotation

Codecov / codecov/patch

zha/zigbee/cluster_handlers/general.py#L637-L638 

Added lines #L637 - L638 were not covered by tests
await self.fast_poll_stop()

def skip_manufacturer_id(self, manufacturer_code: int) -> None:
Expand Down
Loading