Skip to content

Properly disconnect on connection failure #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

Properly disconnect on connection failure #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions zigpy_zigate/zigbee/application.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,16 @@

async def connect(self):
api = await ZiGate.new(self._config[zigpy.config.CONF_DEVICE], self)
await api.set_raw_mode()
await api.set_time()

(_, version), lqi = await api.version()
try:
await api.set_raw_mode()
await api.set_time()

(_, version), lqi = await api.version()
except Exception:
await api.disconnect()
raise

Check warning on line 52 in zigpy_zigate/zigbee/application.py

View check run for this annotation

Codecov / codecov/patch

zigpy_zigate/zigbee/application.py#L50-L52 

Added lines #L50 - L52 were not covered by tests

major, minor = version.to_bytes(2, "big")
self.version = f"{major:x}.{minor:x}"

Expand Down