Add translation_placeholders to v2 quirks #1668
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for translation_placeholders functionality to the v2 quirks system, allowing entities to have dynamic translation values.
- Adds
translation_placeholdersfield to entity metadata classes - Updates all entity creation methods to accept the new parameter
- Extends entity modification capabilities to include translation placeholder updates
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1668 +/- ##
=======================================
Coverage 99.31% 99.31%
=======================================
Files 62 62
Lines 12043 12045 +2
=======================================
+ Hits 11960 11962 +2
Misses 83 83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheJulianJES
approved these changes
Sep 18, 2025
There was a problem hiding this comment.
The changes look good. Thanks!
I can solve the conflict in #1652 later.
|
Any news about this? |
|
Sorry, I'll be aiming to get this into 2025.11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added as kwarg only to avoid breaking changes (may conflict with #1652)
Needed for zigpy/zha#533