Upgrade logging to use Events

[pauln]

add_to_log has been deprecated since Moodle 2.7. This patch adds an event and triggers it instead of calling add_to_log; a version bump is included in order to register the event class.

Moodle 2.7 is already defined as the minimum supported version in version.php, so no change to the plugin's requirements is necessary to allow for this change.

[zigtan]

@pauln , ok sure. Looks good to me.

Please go ahead and merge. Thanks.

[pauln]

Sorry - I just realised that the commit didn't include the version bump (I might have changed the wrong copy of the file). I've just force-pushed an amended commit which includes the version bump (but is otherwise identical).

I don't have permission to merge PRs on your repo, @ztan-echo360 - you'll need to hit the merge button if you're happy with the change :-)

By the way, there'll be several more coming - now that this repo has been restructured to support usage as a git submodule, I'm working through our local fixes/improvements and submitting PRs for them. It's up to you which ones you take, but hopefully everything I submit will be of some value.

[zigtan]

@pauln , ok sure. I'll review the other changes later today and update the master shortly.

[pauln]

Thanks, @ztan-echo360. It's the end of the work day here, so that's it for now - but there'll be more in the next day or two. Up to you whether you want to work through the PRs I've submitted so far, or wait a couple of days until I've prepared and sent the rest of the PRs, so you can work through all of them in one go.

[pauln]

Hi @ztan-echo360,
I think I've got all of the main PRs submitted now. I also have patches which address a couple of more recent deprecations / core Moodle changes (site-wide "requiremodintro" setting, change to standard_intro_elements instead of add_intro_module), but they would require increasing the Moodle version requirement. If you're happy to either drop support for 2.7/2.8, or create version-specific branches of the plugin, I can prepare PRs for those too.