Skip to content

Call e.preventDefault() in event handlers when picking link target #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pauln wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Call e.preventDefault() in event handlers when picking link target #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions library/echolink.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ M.mod_echolink.init = function(Y, args) {


function essCourseEventHandler(e) {
e.preventDefault();

var echolinkEventURL = essCourseEventURL + e.target.get('id');
var callbackHandler = {
success: function(o) {
Expand Down Expand Up @@ -98,6 +100,8 @@ M.mod_echolink.init = function(Y, args) {


function essSectionEventHandler(e) {
e.preventDefault();

var echolinkEventURL = essSectionEventURL + e.target.get('id');

var callbackHandler = {
Expand Down Expand Up @@ -138,6 +142,7 @@ M.mod_echolink.init = function(Y, args) {


function essECPPresentationEventHandler(e) {
e.preventDefault();

// Check if selected Echo360 Link is for ECP or Presentation
if(e.target.get('id').indexOf('ess/portal/section/') != -1) { // ESS ECP Link
Expand Down