Initialise $error_message in seamless login function#25
Open
pauln wants to merge 2 commits intozigtan:masterfrom
Open
Initialise $error_message in seamless login function#25pauln wants to merge 2 commits intozigtan:masterfrom
pauln wants to merge 2 commits intozigtan:masterfrom
Conversation
$error_message was undefined if there was no error, as it wasn't being initialised. Later in the function, it's compared to an empty string, so should be initialised to that value.
The indentation in the echolink_ess_oauth_seamless_login function was inconsistent (a mix of tabs and spaces, as well as different amounts of indentation on different lines), which made it hard to read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$error_message was undefined if there was no error, as it wasn't being initialised. Later in the function, it's compared to an empty string, so should be initialised to that value.
The second commit makes this function more readable by making the indentation consistent (and conform to Moodle coding style); the rest of locallib.php could do with similar treatment, but I've only fixed the indentation in the function I was already working on for now.