Ensure that workspace/Configuration is always used with editors that support it
#2416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that ZLS has been relying on the outdated
workspace/didChangeConfigurationrequest even in editors that supportedworkspace/Configuration.This change may require updating the user config to ensure ZLS options set in the editor config continue to work.
Sublime Text
{ "clients": { "zls": { "enabled": true, // ... "settings": { - "zig_exe_path": "/path/to/zig_executable" - "enable_build_on_save": true + "zls": { + "zig_exe_path": "/path/to/zig_executable" + "enable_build_on_save": true + } } } } }Helix
Zed
{ "lsp": { "zls": { "binary": {...}, "settings": { - "enable_build_on_save": true, - "zig_exe_path": "/path/to/zig_executable" + "zls": { + "enable_build_on_save": true, + "zig_exe_path": "/path/to/zig_executable" + } } } } }Neovim
lspconfig.zls.setup { cmd = { '/path/to/zls_executable' }, settings = { - enable_build_on_save = true, - zig_exe_path = '/path/to/zig_executable' + zls = { + enable_build_on_save = true, + zig_exe_path = '/path/to/zig_executable' + } } }