rewrite uri logic to always perform normalization #2495
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot assume that client and server will use the exact same uri string to refer the same file. To remedy this, we will now always run some normalization rules before using a uri. Previously we would sometimes use client uri strings as is and sometimes normalize them. fixes #2465
I've also made sure that UNC paths on windows are properly handled. Still depends on ziglang/zig#25681 to fix import lookups.