Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Step 2.6
Task
Seal the traits defined in this step's crate in the following way:
MyIteratorExttrait fully sealed. Do it manually, using the [sealed] crate or a similar one is not allowed.MyErrortrait partially sealed. Only seal the method marked with#[doc(hidden)]attribute.Solution
Added required seals and tests. For create root
impl MyIteratorExt for Dummy {}would show conflicting implementation error because we have blanked implementation for iterators, but for external crates it would be sealed.