Merged
Conversation
Signed-off-by: Sammy Huang <sammy.huang@zilliz.com>
b56e1bf to
41231c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for AWS Client-Side Encryption (CSE) in the BYOC I project, allowing users to enable CSE for Milvus data with either an automatically created KMS key or an existing KMS key. It adds a new Terraform module for KMS key and IAM role management, updates configuration files to expose new variables and outputs, and documents the new encryption options in the project README.
Encryption (KMS) Integration:
enable_aws_cse,aws_cse_exiting_key_arn) and outputs (cse_key_arn). [1] [2] [3] [4] [5]modules/aws_byoc_i/kms) to provision a multi-region symmetric KMS key, alias, IAM role, and role policy for cross-account access, with validation for input variables. [1] [2]Configuration and Resource Updates:
main.tfto conditionally create the KMS module and integrate its outputs into the project resource, ensuring proper dependency management. [1] [2]Documentation Improvements:
cse_key_arn.These changes collectively enable secure client-side encryption for Milvus data in AWS BYOC deployments, improve flexibility for key management, and provide clear documentation for users.