Open
Conversation
added 2 commits
September 12, 2025 00:23
|
|
||
| replace ( | ||
| cloud.google.com/go => cloud.google.com/go v0.115.0 | ||
| github.com/zillow/zfmt => ../zfmt |
Member
There was a problem hiding this comment.
zkafka/go.mod shouldn't have the dependency on zfmt, zfmt/avro zfmt/json yet. Thats one of the big pushes of this change. We'll create a functional interface that zfmt and its subpackages adhere to (implicitly, no explicit coupling).
Now, you want to know these codebasese work well together. For that i'd introduce a packge called testfmt (with its own go.mod). You can update how the tests are run lcoally and in the pipeline to stitch together the coverage from the two. That way when people run go get zkafka, they won't have to take on zfmt and its child submod dependencies. But your tests will document how to use the two together. And give you a chance to guarantee correctness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.