Conversation
8a35fa0 to
6df1301
Compare
There was a problem hiding this comment.
Absolutely awesome job!
I've just one small nit-pick, and if @adamgfraser doesn't have anything to add, I think we can merge 🚀 (but before doing that, we should coordinate somehow with the twin PR #449 )
The jobs are restarted, so 🤞 it will be all green now 🍀
|
|
||
| /** | ||
| * Composition law | ||
| * traverse (Compose . fmap g . f) ta = Compose . fmap (traverse g) . traverse f $ ta |
There was a problem hiding this comment.
I would be worried that the Haskell names could confuse some users/contributors. I think we should use the ZIO Prelude terminology here, so foreach (instead of traverse) and map (instead of fmap).
|
Looking at the builds again, some were not spurious failures. 2.11 may need more explicit type arguments and dotty seems to need more parentheses. |
|
@Badmoonz I tried adding tests for nested (and product of) |
closes #373