fix: print previous error when failing to search another cde

[Its-Just-Nans]

Hello

This MR doesn't hide the previous error when search for a new cde

First step fix for (returns the real error)

• part fix Appending to zip file with non-UTF-8 filenames corrupts the central directory #361
• part fix Panic Could not find EOCD for a valid file #454

[gemini-code-assist]

Summary of Changes

Hello @Its-Just-Nans, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the system might obscure the original error when failing to locate or process a Central Directory Entry (CDE) within a ZIP archive. By introducing explicit error tracking, the changes ensure that the most pertinent error is preserved and returned, significantly improving the clarity and debuggability of archive processing failures. This directly resolves the problem described in issue #454.

Highlights

• Improved Error Reporting: Introduced a mechanism to track and return the most relevant error encountered during the search and parsing of Central Directory Entries (CDEs) in ZIP archives.
• Error Preservation: A last_err variable was added to src/read.rs to store errors from previous attempts to find or parse CDEs, ensuring that critical diagnostic information is not lost.
• Refined CDE Search Logic: Modified the CDE search loop to prioritize returning a previously recorded error if a subsequent search for the central directory fails, or to store new errors from CDE parsing for later reporting.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes an issue where a parsing error of a central directory entry could be hidden if finding the next candidate fails. The change correctly stores the last parsing error and returns it in case no more candidates can be found. I've added a couple of suggestions to make the implementation more concise and idiomatic.