Skip to content

fix: Default "platform" field in zip files should be set to the local platform, rather than always "Unix" (#470) #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: Default "platform" field in zip files should be set to the local platform, rather than always "Unix" (#470) #471

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b85c58
Fix #470:Default "platform" field in zip files is set to "Unix" on
Nov 5, 2025
cb21fca
fix: platform set to Dos on windows and set to Unix on others.
Nov 5, 2025
a157695
Merge branch 'master' into fix-issue-470
Pr0methean Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,8 +712,13 @@ impl ZipFileData {
let permissions = options.permissions.unwrap_or(0o100644);
let file_name: Box<str> = name.to_string().into_boxed_str();
let file_name_raw: Box<[u8]> = file_name.bytes().collect();
let system = if cfg!(windows) {
System::Dos
} else {
System::Unix
};
let mut local_block = ZipFileData {
system: System::Unix,
system: system,
Copy link

@pzhlkj6612 pzhlkj6612 Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify:

Suggested change
system: system,
system,

version_made_by: DEFAULT_VERSION,
flags: 0,
encrypted: options.encrypt_with.is_some() || {
Expand Down
Loading