feat: publicly export and document the zip64 threshold constants #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Pr0methean thanks so much for creating this PR! I have recreated signed commits with your fixes at https://github.com/zip-rs/zip2/compare/master...cosmicexplorer:oldpr402?expand=1 or 681b02c, 77ce0cc, and 2e9ed0d. However, it looks like the added test is failing: failures:
---- src/spec.rs - spec::ZIP64_BYTES_THR (line 24) stdout ----
Test executable failed (exit status: 101).
stderr:
thread 'main' panicked at src/spec.rs:18:2:
assertion failed: zip.start_file("one.dat", options).is_err()I'll take a look into why this behavior changed since #402 and try to bisect the failure. |
|
Replaced by #79. |
auto-merge was automatically disabled
May 2, 2024 18:51
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces zip-rs/zip-old#402.