fix(ci): repair three release-triggered workflow failures#147
Conversation
- signed-releases: trigger on workflow_run instead of release:published to avoid race condition where assets aren't uploaded yet - sbom: add --clobber flag to avoid conflict with release.yml's sbom job - changelog: create PR instead of direct commit to respect branch protection
Benchmark ResultsNo benchmarks configured. Add benchmarks to benches/ directory. Full results available in CI artifacts. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
=======================================
Coverage 94.93% 94.93%
=======================================
Files 25 25
Lines 10182 10183 +1
=======================================
+ Hits 9666 9667 +1
Misses 516 516 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Repairs release-related GitHub Actions workflows that failed during v0.4.0-rc1 by removing race conditions, avoiding release asset upload conflicts, and complying with branch protection.
Changes:
- Switch Signed Releases to trigger on
workflow_runafter theReleaseworkflow completes (instead ofrelease: published). - Add
--clobberto SBOM release asset upload to handle name conflicts. - Update the changelog workflow to open a PR rather than committing directly to
main.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/signed-releases.yml | Trigger signing after the Release workflow completes; download/upload assets by tag and update release notes. |
| .github/workflows/sbom.yml | Make SBOM attachment to releases overwrite-safe via --clobber. |
| .github/workflows/changelog.yml | Replace direct push-to-main with branch + PR creation for changelog updates. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Benchmark ResultsNo benchmarks configured. Add benchmarks to benches/ directory. Full results available in CI artifacts. |
Benchmark ResultsNo benchmarks configured. Add benchmarks to benches/ directory. Full results available in CI artifacts. |
Benchmark ResultsNo benchmarks configured. Add benchmarks to benches/ directory. Full results available in CI artifacts. |
Rng::random() was removed in newer rand versions. Rng::fill() is stable across both 0.9 and 0.10.
zircote
force-pushed
the
fix/release-workflows
branch
from
87597cc to
1a79570
Compare
Benchmark ResultsNo benchmarks configured. Add benchmarks to benches/ directory. Full results available in CI artifacts. |
Summary
Three workflows failed during the v0.4.0-rc1 release:
release: publishedbefore binaries were uploaded (race condition). Fixed by triggering onworkflow_runafter the Release workflow completes.release.yml. Fixed by adding--clobberflag.main, blocked by branch protection. Fixed by creating a PR instead.Test plan