Skip to content

Commit 8173b9a

Browse files
authored
Merge pull request #214 from Donnnno/isEmpty
replace () > 0) with isempty
2 parents 0aa09a9 + b195ca2 commit 8173b9a

27 files changed

+62
-62
lines changed

library/src/main/java/candybar/lib/activities/CandyBarMainActivity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -865,7 +865,7 @@ private void initNavigationViewHeader() {
865865
image.setRatio(16, 9);
866866
}
867867

868-
if (titleText.length() == 0) {
868+
if (titleText.isEmpty()) {
869869
container.setVisibility(View.GONE);
870870
} else {
871871
title.setText(titleText);

library/src/main/java/candybar/lib/activities/CandyBarSplashActivity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ protected boolean run() {
153153
return false;
154154
}
155155

156-
if (list.size() > 0 && list.get(0) instanceof Map) {
156+
if (!list.isEmpty() && list.get(0) instanceof Map) {
157157
Map<?, ?> map = (Map<?, ?>) list.get(0);
158158
String thumbUrl = JsonHelper.getThumbUrl(map);
159159

library/src/main/java/candybar/lib/adapters/AboutAdapter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,9 @@ public AboutAdapter(@NonNull Context context, int spanCount) {
9191

9292
mShowContributors = mContext.getResources().getBoolean(R.bool.show_contributors_dialog);
9393

94-
mShowPrivacyPolicy = mContext.getResources().getString(R.string.privacy_policy_link).length() > 0;
94+
mShowPrivacyPolicy = !mContext.getResources().getString(R.string.privacy_policy_link).isEmpty();
9595

96-
mShowTerms = mContext.getResources().getString(R.string.terms_and_conditions_link).length() > 0;
96+
mShowTerms = !mContext.getResources().getString(R.string.terms_and_conditions_link).isEmpty();
9797

9898
mShowExtraInfo = mShowContributors || mShowPrivacyPolicy || mShowTerms;
9999

library/src/main/java/candybar/lib/adapters/FAQsAdapter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ class ViewHolder extends RecyclerView.ViewHolder {
131131
public void search(String string) {
132132
String query = string.toLowerCase(Locale.getDefault()).trim();
133133
mFAQs.clear();
134-
if (query.length() == 0) mFAQs.addAll(mFAQsAll);
134+
if (query.isEmpty()) mFAQs.addAll(mFAQsAll);
135135
else {
136136
for (int i = 0; i < mFAQsAll.size(); i++) {
137137
FAQs faq = mFAQsAll.get(i);

library/src/main/java/candybar/lib/adapters/HomeAdapter.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ public HomeAdapter(@NonNull Context context, @NonNull List<Home> homes, int orie
137137
}
138138

139139
String link = mContext.getResources().getString(R.string.google_play_dev);
140-
if (link.length() > 0) {
140+
if (!link.isEmpty()) {
141141
mItemsCount += 1;
142142
mShowMoreApps = true;
143143
}
@@ -208,7 +208,7 @@ public void onBindViewHolder(@NonNull RecyclerView.ViewHolder holder, int positi
208208
HeaderViewHolder headerViewHolder = (HeaderViewHolder) holder;
209209

210210
String home_title_text = mContext.getResources().getString(R.string.home_title);
211-
if (home_title_text.length() > 0) {
211+
if (!home_title_text.isEmpty()) {
212212
headerViewHolder.title.setText(home_title_text);
213213
} else {
214214
headerViewHolder.title.setVisibility(View.GONE);
@@ -303,7 +303,7 @@ public boolean onResourceReady(Bitmap bitmap, Object model, Target<Bitmap> targe
303303
contentViewHolder.title.setTypeface(TypefaceHelper.getMedium(mContext));
304304
contentViewHolder.title.setText(mHomes.get(finalPosition).getTitle());
305305

306-
if (mHomes.get(finalPosition).getSubtitle().length() > 0) {
306+
if (!mHomes.get(finalPosition).getSubtitle().isEmpty()) {
307307
contentViewHolder.subtitle.setText(mHomes.get(finalPosition).getSubtitle());
308308
contentViewHolder.subtitle.setVisibility(View.VISIBLE);
309309
}
@@ -428,15 +428,15 @@ private class HeaderViewHolder extends RecyclerView.ViewHolder implements View.O
428428
card.setCardElevation(0);
429429
}
430430

431-
if (mContext.getResources().getString(R.string.rate_and_review_link).length() == 0) {
431+
if (mContext.getResources().getString(R.string.rate_and_review_link).isEmpty()) {
432432
rate.setVisibility(View.GONE);
433433
}
434434

435-
if (mContext.getResources().getString(R.string.share_link).length() == 0) {
435+
if (mContext.getResources().getString(R.string.share_link).isEmpty()) {
436436
share.setVisibility(View.GONE);
437437
}
438438

439-
if ((!mContext.getResources().getBoolean(R.bool.enable_check_update)) || (CandyBarApplication.getConfiguration().getConfigHandler().configJson(mContext).length() == 0)) {
439+
if ((!mContext.getResources().getBoolean(R.bool.enable_check_update)) || (CandyBarApplication.getConfiguration().getConfigHandler().configJson(mContext).isEmpty())) {
440440
update.setVisibility(View.GONE);
441441
}
442442

library/src/main/java/candybar/lib/adapters/IconsAdapter.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ public boolean onPrepareActionMode(ActionMode mode, Menu menu) {
118118
mode.setTitle(mContext.getResources().getString(R.string.items_selected, mSelectedIcons.size()));
119119
menu.findItem(R.id.menu_select_all).setIcon(mSelectedIcons.size() == mIcons.size()
120120
? R.drawable.ic_toolbar_select_all_selected : R.drawable.ic_toolbar_select_all);
121-
menu.findItem(R.id.menu_delete).setVisible(mSelectedIcons.size() > 0);
121+
menu.findItem(R.id.menu_delete).setVisible(!mSelectedIcons.isEmpty());
122122
return true;
123123
}
124124

@@ -382,7 +382,7 @@ public void search(String string) {
382382
String query = string.toLowerCase(Locale.ENGLISH).trim();
383383

384384
mIcons = new ArrayList<>();
385-
if (query.length() == 0) mIcons.addAll(mIconsAll);
385+
if (query.isEmpty()) mIcons.addAll(mIconsAll);
386386
else {
387387
for (int i = 0; i < mIconsAll.size(); i++) {
388388
Icon icon = mIconsAll.get(i);
@@ -394,7 +394,7 @@ public void search(String string) {
394394
}
395395
}
396396

397-
if (mIcons.size() == 0) {
397+
if (mIcons.isEmpty()) {
398398
CandyBarApplication.getConfiguration().getAnalyticsHandler().logEvent(
399399
"click",
400400
new HashMap<String, Object>() {{

library/src/main/java/candybar/lib/adapters/PresetsAdapter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ public void setType(String type) {
231231
List<String[]> requiredApps = getRequiredApps(type);
232232
LinearLayout linearLayout = itemView.findViewById(R.id.container);
233233

234-
if (requiredApps.size() > 0) {
234+
if (!requiredApps.isEmpty()) {
235235
for (String[] requiredApp : requiredApps) {
236236
View item = LayoutInflater.from(mContext).inflate(R.layout.fragment_presets_item_header_list, linearLayout, false);
237237
((TextView) item.findViewById(R.id.name)).setText(requiredApp[0]);
@@ -296,7 +296,7 @@ public void onClick(View view) {
296296
intent.setData(Uri.parse("kfile://" + mContext.getPackageName() + "/" + preset.getPath()));
297297
}
298298

299-
if (getRequiredApps(type).size() > 0) {
299+
if (!getRequiredApps(type).isEmpty()) {
300300
new MaterialDialog.Builder(mContext)
301301
.typeface(TypefaceHelper.getMedium(mContext), TypefaceHelper.getRegular(mContext))
302302
.content(R.string.presets_required_apps_not_installed)

library/src/main/java/candybar/lib/adapters/SettingsAdapter.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,21 +102,21 @@ public void onBindViewHolder(RecyclerView.ViewHolder holder, int position) {
102102
ContentViewHolder contentViewHolder = (ContentViewHolder) holder;
103103
Setting setting = mSettings.get(position);
104104

105-
if (setting.getTitle().length() == 0) {
105+
if (setting.getTitle().isEmpty()) {
106106
contentViewHolder.title.setVisibility(View.GONE);
107107
contentViewHolder.divider.setVisibility(View.GONE);
108108
contentViewHolder.container.setVisibility(View.VISIBLE);
109109

110110
contentViewHolder.subtitle.setText(setting.getSubtitle());
111111

112-
if (setting.getContent().length() == 0) {
112+
if (setting.getContent().isEmpty()) {
113113
contentViewHolder.content.setVisibility(View.GONE);
114114
} else {
115115
contentViewHolder.content.setText(setting.getContent());
116116
contentViewHolder.content.setVisibility(View.VISIBLE);
117117
}
118118

119-
if (setting.getFooter().length() == 0) {
119+
if (setting.getFooter().isEmpty()) {
120120
contentViewHolder.footer.setVisibility(View.GONE);
121121
} else {
122122
contentViewHolder.footer.setText(setting.getFooter());

library/src/main/java/candybar/lib/adapters/WallpapersAdapter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ public boolean onResourceReady(Bitmap resource, Object model, Target<Bitmap> tar
127127
public void search(String string) {
128128
String query = string.toLowerCase(Locale.getDefault()).trim();
129129
mWallpapers.clear();
130-
if (query.length() == 0) mWallpapers.addAll(mWallpapersAll);
130+
if (query.isEmpty()) mWallpapers.addAll(mWallpapersAll);
131131
else {
132132
for (int i = 0; i < mWallpapersAll.size(); i++) {
133133
Wallpaper wallpaper = mWallpapersAll.get(i);

library/src/main/java/candybar/lib/adapters/dialog/CreditsAdapter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ public View getView(int position, View view, ViewGroup viewGroup) {
103103
}
104104
});
105105

106-
if (credit.getContribution().length() == 0) {
106+
if (credit.getContribution().isEmpty()) {
107107
holder.subtitle.setVisibility(View.GONE);
108108
} else {
109109
holder.subtitle.setVisibility(View.VISIBLE);

0 commit comments

Comments
 (0)