Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an “Active chat” contact filter intended to show only contacts with at least one message, supporting the broader goal from Issue #279 of making chat-centric workflows easier.
Changes:
- Introduces a new
ContactTypeFilter.chattype and exposes it in the contacts filter menu as “Active chat”. - Implements the “active chat” filtering logic in
ContactsScreenbased on whether a contact has messages. - Adds the
listFilter_activeChatlocalization string across supported locales and generated localization files.
Reviewed changes
Copilot reviewed 41 out of 41 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/widgets/list_filter_widget.dart | Adds “Active chat” option to the contacts filter menu UI. |
| lib/utils/contact_filter_types.dart | Adds a new ContactTypeFilter enum value used by the UI and filtering logic. |
| lib/screens/discovery_screen.dart | Updates switch exhaustiveness for the new type filter value. |
| lib/screens/contacts_screen.dart | Implements filtering for the new “Active chat” type; adjusts search/group header layout sizing. |
| lib/l10n/app_en.arb | Adds listFilter_activeChat string. |
| lib/l10n/app_de.arb | Adds listFilter_activeChat string. |
| lib/l10n/app_es.arb | Adds listFilter_activeChat string. |
| lib/l10n/app_fr.arb | Adds listFilter_activeChat string. |
| lib/l10n/app_it.arb | Adds listFilter_activeChat string. |
| lib/l10n/app_ja.arb | Adds listFilter_activeChat string. |
| lib/l10n/app_ko.arb | Adds listFilter_activeChat string. |
| lib/l10n/app_nl.arb | Adds listFilter_activeChat string. |
| lib/l10n/app_pl.arb | Adds listFilter_activeChat string. |
| lib/l10n/app_pt.arb | Adds listFilter_activeChat string. |
| lib/l10n/app_ru.arb | Adds listFilter_activeChat string. |
| lib/l10n/app_sk.arb | Adds listFilter_activeChat string. |
| lib/l10n/app_sl.arb | Adds listFilter_activeChat string. |
| lib/l10n/app_sv.arb | Adds listFilter_activeChat string. |
| lib/l10n/app_uk.arb | Adds listFilter_activeChat string. |
| lib/l10n/app_zh.arb | Adds listFilter_activeChat string. |
| lib/l10n/app_localizations.dart | Adds new localization getter in the base localization interface. |
| lib/l10n/app_localizations_en.dart | Adds generated getter for listFilter_activeChat. |
| lib/l10n/app_localizations_de.dart | Adds generated getter for listFilter_activeChat. |
| lib/l10n/app_localizations_es.dart | Adds generated getter for listFilter_activeChat. |
| lib/l10n/app_localizations_fr.dart | Adds generated getter for listFilter_activeChat. |
| lib/l10n/app_localizations_it.dart | Adds generated getter for listFilter_activeChat. |
| lib/l10n/app_localizations_ja.dart | Adds generated getter for listFilter_activeChat. |
| lib/l10n/app_localizations_ko.dart | Adds generated getter for listFilter_activeChat. |
| lib/l10n/app_localizations_nl.dart | Adds generated getter for listFilter_activeChat. |
| lib/l10n/app_localizations_pl.dart | Adds generated getter for listFilter_activeChat. |
| lib/l10n/app_localizations_pt.dart | Adds generated getter for listFilter_activeChat. |
| lib/l10n/app_localizations_ru.dart | Adds generated getter for listFilter_activeChat. |
| lib/l10n/app_localizations_sk.dart | Adds generated getter for listFilter_activeChat. |
| lib/l10n/app_localizations_sl.dart | Adds generated getter for listFilter_activeChat. |
| lib/l10n/app_localizations_sv.dart | Adds generated getter for listFilter_activeChat. |
| lib/l10n/app_localizations_uk.dart | Adds generated getter for listFilter_activeChat. |
| lib/l10n/app_localizations_zh.dart | Adds generated getter for listFilter_activeChat. |
| lib/l10n/app_localizations_bg.dart | Adds generated getter for listFilter_activeChat. |
| lib/l10n/app_localizations_hu.dart | Adds generated getter for listFilter_activeChat. |
| lib/l10n/app_localizations_bg.dart | Adds generated getter for listFilter_activeChat. |
| lib/l10n/app_bg.arb | Adds listFilter_activeChat string. |
| lib/l10n/app_hu.arb | Adds listFilter_activeChat string. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I added a "Active Chat" filter, which Displays all Chats which have at least one Message. (according to my proposal in Issue #279)
To delete from List you will have to go into the chat and "Clear Chat" in the Filter menu.
Best Regards
Eric Zimmermann
PS: I also gave a little more space to the search bar.