[Review] Add caching support for IdentityProviderStorageProvider.getForLogin operations

[AncD8972]

Mirrored from ai-code-review-evaluation#2.

Test 2

[AncD8972]

🔴 HIGH | logic_defect

Test cleanup issue: cleanup code references 'alias' but IDPs are created with specific aliases like 'idp-alias-' + i. This will cause cleanup to fail.

💡 Suggestion: Fix the cleanup code to use the correct alias or remove cleanup calls as they seem to be using wrong identifiers.

Suggested change

	for (int i = 10; i < 20; i++) {
	getCleanup().addCleanup(() -> testRealm().identityProviders().get("idp-alias-" + 20).remove());

[AncD8972]

🔴 HIGH | logic_defect

Same cleanup issue - using 'alias' instead of the actual IDP alias 'idp-alias-20'.

💡 Suggestion: Fix the cleanup alias reference.

Suggested change

	assertNotNull(identityProviderListQuery);
	getCleanup().addCleanup(() -> testRealm().identityProviders().get("idp-alias-20").remove());

[AncD8972]

🟡 MEDIUM | static_defect

Potential NPE: idpDelegate.getForLogin() could return null, which would cause NPE when calling .map() on the result.

💡 Suggestion: Add null check or handle null stream appropriately.

Suggested change

	String cacheKey = cacheKeyForLogin(getRealm(), mode);
	if (isInvalid(cacheKey)) {
	Stream<IdentityProviderModel> result = idpDelegate.getForLogin(mode, organizationId);
	return result != null ? result.map(this::createOrganizationAwareIdentityProviderModel) : Stream.empty();
	}

[AncD8972]

🟡 MEDIUM | static_defect

Potential NPE: idpDelegate.getForLogin() could return null, causing NPE in collect operation.

💡 Suggestion: Add null check before collecting stream.

Suggested change

	Stream<IdentityProviderModel> idpStream = idpDelegate.getForLogin(mode, organizationId);
	if (idpStream == null) {
	cached = Set.of();
	} else {
	cached = idpStream.map(IdentityProviderModel::getInternalId).collect(Collectors.toSet());
	}

[AncD8972]

🟡 MEDIUM | static_defect

Potential NPE: idpDelegate.getForLogin() could return null, causing NPE in collect operation.

💡 Suggestion: Add null check before collecting stream.

Suggested change

	} else {
	Stream<IdentityProviderModel> idpStream = idpDelegate.getForLogin(mode, organizationId);
	if (idpStream == null) {
	cached = Set.of();
	} else {
	cached = idpStream.map(IdentityProviderModel::getInternalId).collect(Collectors.toSet());
	}

[AncD8972]

🟡 MEDIUM | static_defect

Potential NPE: idpDelegate.getForLogin() could return null, causing NPE when calling .map().

💡 Suggestion: Add null check before mapping stream.

Suggested change

	}
	Set<IdentityProviderModel> identityProviders = new HashSet<>();
	if (idp == null) {
	realmCache.registerInvalidation(cacheKey);
	Stream<IdentityProviderModel> result = idpDelegate.getForLogin(mode, organizationId);
	return result != null ? result.map(this::createOrganizationAwareIdentityProviderModel) : Stream.empty();
	}