Add compress, decompress_unchecked, and is_in_prime_subgroup methods#9
Open
Add compress, decompress_unchecked, and is_in_prime_subgroup methods#9
Conversation
|
Do we have any additional trust assumptions regarding new cold storage EC points format? |
Author
If I haven't made any mistakes in zkBob/libzeropool-zkbob#8 then we don't have any additional trust assumptions. We still check everything that we checked before but in a different order. |
r0wdy1
approved these changes
Mar 17, 2023
6f26a94 to
a6a9b53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, the following was done:
EdwardPoint::compressmethod that packs X coordinate and the sign of Y in 32 bytes.EdwardPoint::decompress_uncheckedmethod that restores the point serialized with the previous method without checking that the point is in the prime subgroup.EdwardPoint::is_in_prime_subgroupmethod that checks that the point is in the prime subgroup.The reason why it could be useful is described at https://github.com/zkBob/zkbob-pool-storage/issues/2.
Refs and implementation examples:
Note: fawkes-crypto uses optimized parameters of twisted edwards curve so the formulas in this PR and in the examples above are different. This transformation is explained in Theorem 4.1 of this proposal.