Add ability to parse coldstorage with different ec points formats#45
Draft
Add ability to parse coldstorage with different ec points formats#45
Conversation
AllFi
changed the title
AllFi
force-pushed
the
feature/decompress_ec_points
branch
from
b615854 to
dc8df7d
Compare
AllFi
requested review from
EvgenKor,
akolotov,
k1rill-fedoseev,
lok52 and
r0wdy1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR the following was done:
BulkDatawas extended withec_points_formatupdate_state_cold_storagenow usesec_points_formatfromBulkDatafor tx parsing.parse_txsstill uses the default ec points format.The open question is whether we need to keep backward compatibility or not. I think it probably isn't worth it because even if clients failed to sync state with the cold storage they still can continue with the usual sync. And the only period when it would be useful is the period when we've already updated the ui but haven't updated the cold storage.
The reason why it could be useful is described at https://github.com/zkBob/zkbob-pool-storage/issues/2.