Open
Conversation
akolotov
requested changes
Dec 15, 2023
AllFi
reviewed
Dec 18, 2023
Co-authored-by: Alexander Filippov <aleksander.fill@gmail.com>
Co-authored-by: Alexander Filippov <aleksander.fill@gmail.com>
Co-authored-by: Kirill Fedoseev <kirill@blockscout.com>
k1rill-fedoseev
approved these changes
Dec 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds yet another layer of security by introducing a set of predefined guardians that would re-do all the proof verification and thus lower the required trust assumptions about honest sequencer.
Architecture
In order to avoid any changes to the Pool contract the PR leverages an already used
OperatorManagerfunctionality in a new way: theMPCGuardcontract instance is entitled as a sole executor for bothtransactandappendDirectDepositmethods.Now in order to be propagated to the Pool the transaction is expected to have a set of additional signatures made by a set of predefined guardians
For the sake of simplicity there are certain limitations and guard rails that could be improved later:
transactandappendDirectDepositareonlyOperatorjust as a last line of defense