fix(ci, clippy): raise MSRV to 1.82, fix rust 1.90 warnings#451
Merged
fix(ci, clippy): raise MSRV to 1.82, fix rust 1.90 warnings#451
Conversation
cgettys-microsoft
changed the title
cgettys-microsoft
force-pushed
the
dev/chgettys/wyzuotlnryxu
branch
from
acfdfe1 to
2084b6b
Compare
Contributor
Author
|
Still working on the MSRV related errors. |
cgettys-microsoft
force-pushed
the
dev/chgettys/wyzuotlnryxu
branch
from
8f81e74 to
89aea33
Compare
cgettys-microsoft
force-pushed
the
dev/chgettys/wyzuotlnryxu
branch
from
89aea33 to
2249489
Compare
cgettys-microsoft
changed the title
Contributor
Author
|
I tried adding --locked, but Rust 1.70.0 still wouldn't compile: 1.76 wasn't enough either, had to go up to 1.82 (which to be fair is still over a year old) to get this to pass in CI. |
cgettys-microsoft
changed the title
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a few new warnings in 1.90.
Update MSRV to 1.82; even adding --locked, I just couldn't get CI to pass with the declared versions and 1.70. If someone else can, obviously that'd be a better solution.