Derives and borrows #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
requested changes
Sep 4, 2020
Comment on lines
+124
to
+125
| Sized + Send + Sync + AsRef<[u8]> + AsMut<[u8]> + Clone + Copy | ||
| + PartialOrd + Ord + PartialEq + Eq + ::std::hash::Hash + 'static |
Member
There was a problem hiding this comment.
These bounds should now be applied to GroupEncoding::Repr and UncompressedEncoding::Repr. Also add use core::hash::Hash at the top of the file instead of the explicit form here.
| /// Normalizes a slice of projective elements so that | ||
| /// conversion to affine is cheap. | ||
| fn batch_normalization(v: &mut [Self]); | ||
| fn batch_normalization<S: ::std::borrow::BorrowMut<Self>>(v: &mut [S]); |
Member
There was a problem hiding this comment.
This change would now apply to Curve::batch_normalize, and would look something like:
use core::borrow::{Borrow, BorrowMut};
...
fn batch_normalize<P: Borrow<Self>, Q: BorrowMut<Self::AffineRepr>>(p: &[P], q: &mut [Q]) {However, when I tried this locally, I ran into issues with &P not implementing Curve, that I wasn't immediately able to figure out how to resolve. Perhaps the P: Borrow<Self> is unnecessary flexibility?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some basic functions to encoded points and makes batch_normalization slightly easier to use