[maimaidx] Update to CiRCLE

[beer-psi]

Needs zkldi/rg-stats#19 merged for the rating changes.

[tachi-repo-bot]

A commit has changed the seeds. View the diff here.

[beer-psi]

+bot diff

[zkldi]

Rg stats merged

[beer-psi]

Nice. Should I wait for a npm release or do I just pin it to a Git revision?

[beer-psi]

Nice. Should I wait for a npm release or do I just pin it to a Git revision?

oh right specifying a Git URL doesn't work anyways because the library's in a subfolder.

[zkldi]

Uh I should do an npm release for you, sorry mb.

[beer-psi]

Sorry but I have to bother you for a patch release on rg-stats: zkldi/rg-stats#20

There are also outright invalid scores on Tachi that would make rg-stats throw. For example, in the dataset, there's a 100.18% FAILED score, when the clear threshold is 80%. The "proper" solution is to fix those lamps, but that affects the score ID, and that requires a lengthy and horrible DB migration. Alternatively, we could do a hack and only provide the lamp on AP/AP+ (since only those lamps have rating bonuses) so that rg-stats doesn't throw:

scoreCalcs: {
    rate: (scoreData, chart) =>
        MaimaiDXRate.calculate(
            scoreData.percent,
            chart.levelNum,
            scoreData.lamp === "ALL PERFECT" || scoreData.lamp === "ALL PERFECT+"
                ? scoreData.lamp
                : undefined
        ),
},

[beer-psi]

Went for fixing the invalid scores (there were about ~1k of them in the dataset) and adding more validation rules to prevent this from happening again.

[beer-psi]

Should be ready for review now. Apologies for all the bother.

[zkldi]

I'm scared of merging migrations just yet. Will possibly do this after work. Postgres migration is 100% happening this march. Not putting it off any longer.