Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for constraint system reconstruction from serialized circuit information. The main purpose is to enable reconstructing a Halo2 constraint system from its serialized CircuitInfo representation, which is useful for verifying proofs without needing the original circuit definition.
Changes:
- Refactored
shape-generatorcrate by splitting largelib.rsinto separate modules (circuit_info,expression,helpers) - Added
reconstruct_cs_from_circuit_infofunction to rebuild constraint systems from serialized data - Renamed
vk-gen-examplescrate tofunctional-testswith comprehensive reconstruction tests - Updated all references to the renamed crate across configuration files
Reviewed changes
Copilot reviewed 21 out of 29 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
crates/verifier-sdk/shape-generator/src/lib.rs |
Refactored to use modular structure; added constraint system reconstruction logic |
crates/verifier-sdk/shape-generator/src/circuit_info.rs |
New module containing CircuitInfo and related types with serialization |
crates/verifier-sdk/shape-generator/src/expression.rs |
New module for indexed expression handling and serialization |
crates/verifier-sdk/shape-generator/src/helpers.rs |
New module with helper functions for encoding/decoding fields and points |
crates/functional-tests/src/tests.rs |
New comprehensive tests for serialization and reconstruction |
crates/functional-tests/src/proofs.rs |
New helper module for proof generation and verification |
crates/functional-tests/src/examples/*.rs |
Updated example circuits with Clone derives for testing |
packages/*/tests/*.move |
Updated comments referencing renamed crate path |
| Various config files | Updated references from vk-gen-examples to functional-tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zkmove-net
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reduce gas consumption, we introduce a verification method based on the native Halo2 verifier. Compared to the previous method based on BN254 algebra, the new method offers significantly higher performance.