Skip to content

Add some files to .gitignore#939

Closed
pmqs wants to merge 3 commits intozlib-ng:developfrom
pmqs:gitignore
Closed

Add some files to .gitignore#939
pmqs wants to merge 3 commits intozlib-ng:developfrom
pmqs:gitignore

Conversation

@pmqs
Copy link
Contributor

@pmqs pmqs commented Jan 19, 2026

Update .gitignore to include these license files

LICENSE.dec.aes
LICENSE.dec.pkcrypt
LICENSE.enc.aes
LICENSE.enc.pkcrypt

test_compat.cc doesn't delete compat.zip on completion - change gets the test harness to delete it.

* Get test_compat.cc to delete compat.zip on termination.
@pmqs pmqs changed the title Add some file to .gitignore Add some files to .gitignore Jan 19, 2026
*/

TEST(compat, final) {
if (mz_os_file_exists("compat.zip") != MZ_OK)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about just removing this file on the next time the tests are run, like where it is created, delete before checking?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about just removing this file on the next time the tests are run, like where it is created, delete before checking?

The point of deleting the file at the end is so that git doesn't see it as an untracked file, like the LICENSE.* files.

Other option is to just include it in .gitignore

@pmqs
Copy link
Contributor Author

pmqs commented Feb 1, 2026

Added compat.zip to .gitignore in addition to getting test/test_compat.cc to delete it. Covers the use case where test/test_compat.cc fails mid-stream and doesn't get the chance to delete it.

Guards against people (like me) accidentally checked in if it ends up in git status land.

.gitignore Outdated
LICENSE.enc.aes
LICENSE.enc.pkcrypt

# test/test_compat.cc can leave compat.zip handing around
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a native speaker, but shouldn't it be "hanging"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a native speaker, but shouldn't it be "hanging"?

It should indeed!

Unfortunately I don't have any excuse :-)

@pmqs pmqs closed this by deleting the head repository Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants