build: avoid MIN macro for Windows#949
Merged
nmoinvaz merged 1 commit intozlib-ng:developfrom Feb 3, 2026
Merged
Conversation
Collaborator
Author
|
@nmoinvaz this PR should be easy, replacing a |
nmoinvaz
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #948.
While we could maybe add some
#import <windows.h>or create our own macros, I feel the overhead is not needed for a single usage of MIN.I use the ternary operator because it's already in use the line just below (
restor =).I also fix the documentation which had some outdated values. We know we're between PPMD8_MIN_ORDER (2) and PPMD8_MAX_ORDER (16), so the rest of the documentation should be a mem_size between
1 << 2-1(2) and1 << 8-1(128).@pmqs