Skip to content

Compiler warning: use of mktemp is dangerous. Fixes #956 #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pmqs wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Compiler warning: use of mktemp is dangerous. Fixes #956 #957

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b2bd5f6
Compiler warning: use of `mktemp` is dangerous. Fixes #956
pmqs Feb 4, 2026
6dd9270
Remove redundant test for no temp_dir
pmqs Feb 6, 2026
d887b15
fix: update temporary file naming to include timestamp for uniqueness…
pmqs Feb 9, 2026
5547931
Change a C99 dynamic stack allocation into a calloc'ed heap allocation
pmqs Feb 9, 2026
743b41e
fix: free allocated memory for temporary path in mz_os_get_temp_path …
pmqs Feb 10, 2026
674c22d
clang-format: remove extra space in free call in mz_os_get_temp_path …
pmqs Feb 10, 2026
47ef7fb
add more frees
pmqs Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions mz_os_posix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ int32_t mz_os_is_symlink(const char *path) {
int32_t mz_os_make_symlink(const char *path, const char *target_path) {
#if defined(NO_SYMLINK)
return MZ_SUPPORT_ERROR;
#else
#else
if (symlink(target_path, path) != 0)
return MZ_INTERNAL_ERROR;
return MZ_OK;
Expand All @@ -352,6 +352,7 @@ int32_t mz_os_read_symlink(const char *path, char *target_path, int32_t max_targ

int32_t mz_os_get_temp_path(char *path, int32_t max_path, const char *prefix) {
const char *tmp_dir = NULL;
char *temp_path = (char *)calloc(max_path, sizeof(char));
int32_t result = 0;

if (!path || max_path <= 0)
Expand All @@ -365,15 +366,30 @@ int32_t mz_os_get_temp_path(char *path, int32_t max_path, const char *prefix) {
if (!tmp_dir)
tmp_dir = "/tmp";

/* Build template path for mktemp: <tmp_dir>/<prefix>XXXXXX */
result = snprintf(path, max_path, "%s/%sXXXXXX", tmp_dir, prefix ? prefix : "");
if (result < 0 || result >= max_path)
/* Build template path for mkdtemp: <tmp_dir>/<prefix>XXXXXX */
result = snprintf(temp_path, max_path, "%s/%sXXXXXX", tmp_dir, prefix ? prefix : "");
if (result < 0 || result >= max_path) {
free(temp_path);
return MZ_BUF_ERROR;
}

/* mktemp replaces XXXXXX with unique characters */
if (!mktemp(path))
/* Create a temporary directory.
mkdtemp replaces XXXXXX with unique characters
*/
if (!mkdtemp(temp_path)) {
free(temp_path);
return MZ_INTERNAL_ERROR;
}

/* Create a filename inside the temporary directory */
/* Use current time for the filename */
result = snprintf(path, max_path, "%s/%lux", temp_path, time(NULL));
if (result < 0 || result >= max_path) {
free(temp_path);
return MZ_BUF_ERROR;
}

free(temp_path);
return MZ_OK;
}

Expand Down
Loading