Create ROS global planner plugin from Hybrid A Star #7
Open
LotfiZ wants to merge 7 commits intozm0612:mainfrom
Open
Create ROS global planner plugin from Hybrid A Star #7LotfiZ wants to merge 7 commits intozm0612:mainfrom
LotfiZ wants to merge 7 commits intozm0612:mainfrom
Conversation
|
Great job, but yeah it's quite not clean. I think you could split it into small commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi dear,
Your implementation is amazing ! thank again for your works.
I tried to wrap your code into a ROS global planner plugin to be able to work with navigation stack. I briefly test it with a real forklift (tricycle drive) and it seems working but i don't guarantee the reliability, specially for obstacle checking - it does not use costmap layers-. In addition, the code might not be clean.
Please feel free to comment or to point something wrong !
Thank you