fix: normalize NamedGroup string for X25519 and X448 to IANA names#477
Merged
zakird merged 1 commit intozmap:masterfrom Feb 19, 2026
Merged
fix: normalize NamedGroup string for X25519 and X448 to IANA names#477zakird merged 1 commit intozmap:masterfrom
zakird merged 1 commit intozmap:masterfrom
Conversation
Contributor
Author
|
cc @dadrian maybe with this minor fix... this time it works out crossing fingers. |
zakird
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the string representation of CurveID 29 and 30 in
tls/tls_names.goecdh_x25519→x25519ecdh_x448→x448Technical details
CurveIDvalues represent TLS NamedGroup identifiers. According to the IANA TLS NamedGroup registry and RFC 8446, the canonical names for groups 29 and 30 are:x25519x448The previous labels (
ecdh_x25519andecdh_x448) were legacy/temporary naming conventions.This mismatch causes downstream schema validation failures in tools (zgrab2) that validate
server_hello.key_share.nameagainst the standard NamedGroup enum.This seems to be the cause of the test integration failure in this zgrab2 PR: zmap/zgrab2#672, where the error is:
zschema.keys.DataValidationException: name: the value ecdh_x25519 is not a valid enum option. This PR is an attempt to fix that error.