Skip to content

Bring back macOS x86 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cerisier merged 6 commits into from
Mar 18, 2026
Merged

Bring back macOS x86 #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aced1f1
Do not use runs_on for cpu targets
cerisier Mar 18, 2026
b5c0027
Bring back macos intel
cerisier Mar 18, 2026
2470627
test
cerisier Mar 18, 2026
05e7c99
test
cerisier Mar 18, 2026
5b90d69
test
cerisier Mar 18, 2026
d69dff9
dylib
cerisier Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions .github/workflows/_build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,13 @@ jobs:
renamed_artifact: libpjrt_cpu.dylib
platform: darwin-arm64
bazel_target: //xla/pjrt/c:pjrt_c_api_cpu_plugin
#TODO(cerisier): There is a issue with the hermetic osx sdk version for x86.
# - target: cpu
# config: "--config=hermetic_macos_x86 --config=remote --config=bzlmod --remote_header=x-buildbuddy-api-key=$BUILDBUDDY_API_KEY"
# artifact: bazel-bin/xla/pjrt/c/libpjrt_c_api_cpu_plugin.so
# renamed_artifact: libpjrt_cpu.dylib
# runs_on: ["runs-on", "runner=32cpu-linux-x64", "image=ubuntu22-amd64"]
# platform: darwin-amd64
# bazel_target: //xla/pjrt/c:pjrt_c_api_cpu_plugin
- target: cpu
config: "--config=hermetic_macos_x86 --config=remote --config=bzlmod --remote_header=x-buildbuddy-api-key=$BUILDBUDDY_API_KEY --//xla/tsl/framework/contraction:disable_onednn_contraction_kernel=True"
artifact: bazel-bin/xla/pjrt/c/libpjrt_c_api_cpu_plugin.dylib
renamed_artifact: libpjrt_cpu.dylib
runs_on: ["runs-on", "runner=32cpu-linux-x64", "image=ubuntu22-amd64"]
platform: darwin-amd64
bazel_target: //xla/pjrt/c:pjrt_c_api_cpu_plugin
- target: cpu
config: "--config=hermetic_linux_x86 --config=remote --config=bzlmod --remote_header=x-buildbuddy-api-key=$BUILDBUDDY_API_KEY"
artifact: bazel-bin/xla/pjrt/c/libpjrt_c_api_cpu_plugin.so
Expand All @@ -66,15 +65,14 @@ jobs:
platform: linux-amd64
bazel_target: //xla/pjrt/c:pjrt_c_api_cpu_plugin
- target: cpu
config: "--config=hermetic_linux_arm64 --config=remote --config=bzlmod --remote_header=x-buildbuddy-api-key=$BUILDBUDDY_API_KEY --platforms @llvm//platforms:linux_arm64"
config: "--config=hermetic_linux_arm64 --config=remote --config=bzlmod --remote_header=x-buildbuddy-api-key=$BUILDBUDDY_API_KEY"
artifact: bazel-bin/xla/pjrt/c/libpjrt_c_api_cpu_plugin.so
renamed_artifact: libpjrt_cpu.so
runs_on: ["runs-on", "runner=32cpu-linux-x64", "image=ubuntu22-amd64"]
platform: linux-arm64
bazel_target: //xla/pjrt/c:pjrt_c_api_cpu_plugin
steps:
- uses: runs-on/action@v1
if: matrix.pjrt.platform != 'darwin-arm64' && matrix.pjrt.platform != 'darwin-amd64'

- name: "Checking out repository"
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion openxla/bazelrc/upstream/.bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ common:remote --remote_cache=grpcs://remote.buildbuddy.io
common:remote --remote_cache_compression
common:remote --remote_download_toplevel
common:remote --nobuild_runfile_links
common:remote --remote_timeout=3600
common:remote --remote_timeout=120
common:remote --noexperimental_throttle_remote_action_building
common:remote --experimental_remote_execution_keepalive
common:remote --grpc_keepalive_time=30s
Expand Down
Loading