Merged
Conversation
- Implement cut operation (Ctrl+X) for selected patterns - Add undo capabilities (Ctrl+Z) - Introduce useContributionHistory hook for state management
- Add a Windows batch script to start the dev environment and log the changes
- add the build_release.bat packaging script and packaging guide doc - simplify the application build process on the windows platform
…tions - removed hard-coded chinese tooltips and used corresponding fields from the translation file
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="frontend/src/components/ContributionCalendar.tsx">
<violation number="1" location="frontend/src/components/ContributionCalendar.tsx:927">
P2: Undo is now wired, but pen/eraser edits don't record a snapshot, so Ctrl/Cmd+Z won't revert drawing changes. Capture a history snapshot when a drawing action begins (e.g., on mouse down before the first setUserContributions) to make undo work for these edits.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| if ((e.metaKey || e.ctrlKey) && !isDrawing) { | ||
| if (e.code === 'KeyZ' && !e.shiftKey) { | ||
| e.preventDefault(); | ||
| undo(); |
Contributor
There was a problem hiding this comment.
P2: Undo is now wired, but pen/eraser edits don't record a snapshot, so Ctrl/Cmd+Z won't revert drawing changes. Capture a history snapshot when a drawing action begins (e.g., on mouse down before the first setUserContributions) to make undo work for these edits.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At frontend/src/components/ContributionCalendar.tsx, line 927:
<comment>Undo is now wired, but pen/eraser edits don't record a snapshot, so Ctrl/Cmd+Z won't revert drawing changes. Capture a history snapshot when a drawing action begins (e.g., on mouse down before the first setUserContributions) to make undo work for these edits.</comment>
<file context>
@@ -871,6 +920,13 @@ function ContributionCalendar({
+ if ((e.metaKey || e.ctrlKey) && !isDrawing) {
+ if (e.code === 'KeyZ' && !e.shiftKey) {
+ e.preventDefault();
+ undo();
+ }
+ }
</file context>
Owner
Author
|
closes #74 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds cut (Ctrl+X) and undo (Ctrl+Z) to the Contribution Calendar using a new history hook, and localizes related messages. Improves editing workflow and removes hard-coded text.
New Features
Refactors
Written for commit 559c237. Summary will update on new commits.