fix graph input/output linked list insertion #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where adding multiple inputs or outputs to a graph causes at most two of them two be inserted. The result is errors such as Input pad "default" with type audio of the filter instance "out2" of abuffersink not connected to any source when calling validate. The fix walks the linked list and appends the new node to the end. This operation is linear, with the assumption that inputs and outputs are small and building the graph happens infrequently. I added a test which reproduces the issue for both inputs and outputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where adding multiple inputs or outputs to a graph causes at most two of them two be inserted. The result is errors such as
Input pad "default" with type audio of the filter instance "out2" of abuffersink not connected to any source
when calling validate. The fix walks the linked list and appends the new node to the end. This operation is linear, with the assumption that inputs and outputs are small and building the graph happens infrequently.
I added a test which reproduces the issue for both inputs and outputs.