Make cached blob cache lazy to avoid eager duplication on copy - #528
Open
wesleybl wants to merge 1 commit into
Open
Make cached blob cache lazy to avoid eager duplication on copy#528wesleybl wants to merge 1 commit into
wesleybl wants to merge 1 commit into
Conversation
Author
|
@jamadden Could you take a look, please? |
With shared_blob_dir=False the blob_dir is a cache and blobs live in the DB. finish() previously moved every stored blob into the cache, so Copy/Paste duplicated gigabytes on disk before first access. Change CachedBlobHelper to clean temp files on finish and populate the cache only on loadBlob/download.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
shared_blob_dir=Falsetheblob_diris a cache and blobs live in theDB.finish()previously moved every stored blob into the cache, so Copy/Paste duplicated gigabytes on disk before first access. ChangeCachedBlobHelperto clean temp files onfinishand populate the cache only on loadBlob/download.Closes #527