Skip to content

ZMS-3: reduce race condition errors when uploading sub-chunk size attachments #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NickOvt wants to merge 4 commits into
base: master
Choose a base branch
from
Open

ZMS-3: reduce race condition errors when uploading sub-chunk size attachments #997

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d841080
ZMS-3: remove no-locking for sub-chunksize attachments
NickOvt Feb 13, 2026
31130ea
update comment
NickOvt Feb 13, 2026
8a91522
refactor gridstore changes
NickOvt Feb 16, 2026
8dbf767
Merge branch 'master' of github.com:zone-eu/wildduck into ZMS-3-2
NickOvt Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions lib/attachments/gridstore-storage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,8 @@ class GridstoreStorage {
return;
}
// most probably a race condition, try again
if (tryCount++ < 5) {
if (/\.chunks /.test(err.message)) {
if (tryCount++ < 20) {
if (err.code === 11000 || /\.chunks /.test(err.message)) {
// Partial chunks detected. Might be because of:
// * another process is inserting the same attachment and thus no "files" entry yet (should not happened though due to locking)
// * previously deleted attachment that has not been properly removed
Expand Down Expand Up @@ -299,18 +299,21 @@ class GridstoreStorage {

// Check how old is the previous chunk
let timestamp = data._id.getTimestamp();
if (timestamp && typeof timestamp.getTime === 'function' && timestamp.getTime() >= Date.now() - 5 * 60 * 1000) {
// chunk is newer than 5 minutes, assume race condition and try again after a while
if (timestamp && typeof timestamp.getTime === 'function' && timestamp.getTime() >= Date.now() - 30 * 60 * 1000) {
// chunk is newer than 30 minutes, assume race condition and try again after a while
return setTimeout(tryStore, 300 + 200 * Math.random());
}

// partial chunks for a probably deleted message detected, try to clean up
setTimeout(() => {
if (returned) {
return;
}
this.cleanupGarbage(id, tryStore);
}, 100 + 200 * Math.random());
setTimeout(
() => {
if (returned) {
return;
}
this.cleanupGarbage(id, tryStore);
},
100 + 200 * Math.random()
);
}
);
} else {
Expand Down