forked from cloudflare/mcp-server-cloudflare
-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade hono from 4.7.6 to 4.10.3 #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zongruxie4
wants to merge
1
commit into
main
Choose a base branch
from
snyk-fix-2d466bbc8d9ff2f92589d7a09fd3f682
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this upgrade to
honois necessary to fix a security vulnerability, this PR is incomplete for a monorepo setup.Incomplete Upgrade: The
honodependency is used by many other packages in this repository (e.g.,apps/ai-gateway,packages/mcp-common, etc.). To fix the vulnerability everywhere and maintain dependency consistency,honoshould be upgraded to4.10.3in allpackage.jsonfiles where it is a dependency.Missing Lock File Update: The
pnpm-lock.yamlfile has not been updated. After updating all thepackage.jsonfiles, please runpnpm installand commit the updatedpnpm-lock.yaml. Without this, the dependency change will not take effect.Merging this PR as-is will result in an inconsistent state, with multiple versions of
honoin the project, and will not fix the vulnerability in other packages.