Skip to content

#277 Prevent EmbeddedDatabaseTestExecutionListener from affecting non-annotated tests #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2024
Merged

#277 Prevent EmbeddedDatabaseTestExecutionListener from affecting non-annotated tests #286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...ase-spring-test/src/main/java/io/zonky/test/db/EmbeddedDatabaseTestExecutionListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@ private void captureTestClassPreparers(TestContext testContext, RefreshMode... r
private void forEachDatabase(TestContext testContext, RefreshMode[] refreshModes, BiConsumer<DatabaseContext, AutoConfigureEmbeddedDatabase> action) {
Set<AutoConfigureEmbeddedDatabase> annotations = AnnotationUtils.getDatabaseAnnotations(testContext.getTestClass());

if (annotations.isEmpty()) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this brings any difference, because it is only used in a .forEach() part. A .forEach() on a empty Set will already do nothing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The real issue was in calling the testContext.getApplicationContext() method below. This method call could trigger eager initialization of Spring context, even without presence of the @AutoConfigureEmbeddedDatabase annotation.

return;
}

ApplicationContext applicationContext = testContext.getApplicationContext();
Environment environment = applicationContext.getEnvironment();

Expand Down
Loading