Skip to content

Conversation

@jakepearson
Copy link

The newest version of liquibase has a version of commons-lang3 that conflicts with the version here. This PR lines them up.

https://github.com/liquibase/liquibase/blob/master/pom.xml#L72

@tomix26
Copy link
Collaborator

tomix26 commented Nov 8, 2024

Thank you for the pull request, I greatly appreciate any help, however, I must decline the change request for the reasons below.

Liquibase is defined as an optional dependency, so the Zonky library doesn't enforce any specific version, and each user can choose any compatible version. If we were to take the version against which tests are run as the "reference" version of Liquibase, it's liquibase-core:4.29.1, which has commons-lang3:3.14.0 as a dependency, while the Zonky library uses commons-lang3:3.15.0. From a semantic versioning perspective, these versions should be compatible.

If you're using a newer version of Liquibase, you must either ensure that liquibase-core transitive dependencies have higher priority (this should be possible through the declaration order in POM) or use the dependency management section to enforce specific library versions that will be compatible with your project.

@jakepearson
Copy link
Author

Thanks for getting back to me. I have a workaround, but wanted to see what you thought. Thanks for the great tool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants