Conversation
patches/Makefile_shlib_patch.patch
Outdated
| + LINK.shared = $(COMPILER) | ||
| + ifdef SHLIB_EXPORTS | ||
| + exports_file = $(SHLIB_EXPORTS:%.txt=%.x) | ||
| +# $(exports_file): $(SHLIB_EXPORTS) |
There was a problem hiding this comment.
can we remove these commented lines
There was a problem hiding this comment.
Yes removed, addressed in Point-1 in commit aff6713
patches/data_patch.patch
Outdated
| */ | ||
| text_to_cstring_buffer(zone, tzname, sizeof(tzname)); | ||
|
|
||
| - type = DecodeTimezoneName(tzname, &val, &tzp); |
There was a problem hiding this comment.
can we guard it with #ifdef MVS in such cases
There was a problem hiding this comment.
Addressed this change in Point-2 in commit aff6713
…tzset at compile unit offset +64206E6F7420696E at entry offset +64206E6F4BD209
…ous shared memory: EDC5113I Bad file descriptor.
…get_encoding_from_locale at compile unit
| ## Specify the default build line, either 'DEV' or 'STABLE' (default: STABLE) | ||
| export ZOPEN_BUILD_LINE="DEV" | ||
|
|
||
| ## Required IF ZOPEN_BUILD_LINE='STABLE' |
There was a problem hiding this comment.
Should we target a STABLE release? Maybe https://github.com/postgres/postgres/releases/tag/REL_18_BETA2 ?
You can set export ZOPEN_STABLE_TAG=REL_18_BETA2
There was a problem hiding this comment.
Addressed this change in commit aff6713
| export ZOPEN_CATEGORIES="database" | ||
|
|
||
| ## Runtime zopen tool dependencies to be installed alongside the tool. | ||
| export ZOPEN_RUNTIME_DEPS="zlib libxml2 libxslt lz4 systemd tcl python perl" |
There was a problem hiding this comment.
If they're statically linked, then we don't need to add the libraries are runtime dependencies
|
|
||
| retry: | ||
| + #ifndef __MVS__ | ||
| rc = fdatasync(fd); |
There was a problem hiding this comment.
Can we replace this with fsync?
There was a problem hiding this comment.
yeah, replaced with fsync and addressed this change in commit aff6713
patches/findtimezone_patch.patch
Outdated
| @@ -231,7 +231,7 @@ compare_tm(struct tm *s, struct pg_tm *p) | ||
| * test time. | ||
| */ | ||
| static int |
There was a problem hiding this comment.
Would a #define tzname _tzname be a less intrusive way to fix this?
There was a problem hiding this comment.
Addressed this change in Point 2 in commit aff6713
| writes * XLOG_BLCKSZ) != XLOG_BLCKSZ) | ||
| die("write failed"); | ||
| +#ifndef __MVS__ | ||
| fdatasync(tmpfile); |
There was a problem hiding this comment.
Suggest changing to fsync for MVS
| @@ -0,0 +1,139 @@ | |||
| diff --git a/src/backend/storage/ipc/waiteventset.c b/src/backend/storage/ipc/waiteventset.c | |||
| index 7c0e66900f9..574ced67132 100644 | |||
| --- a/src/backend/storage/ipc/waiteventset.c | |||
There was a problem hiding this comment.
I'd suggest unsetting WAIT_USE_EPOLL in case you miss a few conditions now or in the future.
#unset WAIT_USE_EPOLL
1. Removed unneccessary comments in file src/Makefile.shlib and added few comments for readablity 2. Added #define for tzname conflict #ifdef __MVS__ #define tzname _tzname #endif 3. Added fsync for __MVS__ target instead of fdatasync
4 participants
Includes patch files up to the build stage.