Feature: Allow zotero:// as valid protocol#4
Open
julkusapiens wants to merge 1 commit intozotero:masterfrom
Open
Feature: Allow zotero:// as valid protocol#4julkusapiens wants to merge 1 commit intozotero:masterfrom
julkusapiens wants to merge 1 commit intozotero:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the
zotero://protocol to be treated as valid in the PDF viewer.Without this change, links using the Zotero protocol are not clickable,
even though Zotero registers and uses this scheme intentionally.
Firefox's pdf.js tries to prevent XSS by limiting the allowed protocols.
Zotero accepting its own protocol is only logical.
This is a minimal one-line change and does not affect existing
protocol handling.