FAO Knowledge Repository: Using dc.type to set detected item type#3586
Open
swifterslb wants to merge 2 commits intozotero:masterfrom
Open
FAO Knowledge Repository: Using dc.type to set detected item type#3586swifterslb wants to merge 2 commits intozotero:masterfrom
swifterslb wants to merge 2 commits intozotero:masterfrom
Conversation
Regarding zotero#3584 and zotero@28dcb3e: Because `dc.type` is still available, we can reuse the scheme of setting Zotero item type according to `dc.type` to set the detected item type. Please see if the codes are OK.
Contributor
Author
|
The only test error is multiples. Please check. |
swifterslb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding #3584 and 28dcb3e:
Because
dc.typeis still available, we can reuse the scheme of setting Zotero item type according todc.typeto set the detected item type. Also fixed an original test case (new URL). Please see if the codes are OK.