Option to download files at sync time#863
Draft
michalrentka wants to merge 3 commits intozotero:masterfrom
Draft
Option to download files at sync time#863michalrentka wants to merge 3 commits intozotero:masterfrom
michalrentka wants to merge 3 commits intozotero:masterfrom
Conversation
mvasilak
reviewed
Mar 1, 2024
Contributor
mvasilak
left a comment
mvasilak
left a comment
There was a problem hiding this comment.
Code looks good so far, a couple of questions from testing.
- Snapshots are not download as well. Is this planned for the future?
- Sync seems to be stuck, even after all files are downloaded.
|
|
||
| case .remote, .remoteMissing, .localAndChangedRemotely: | ||
| case .remote, .localAndChangedRemotely: | ||
| DDLogInfo("AttachmentDownloader: batch download remote\(location == .remoteMissing ? "ly missing" : "") file \(attachment.key)") |
Contributor
There was a problem hiding this comment.
Suggested change
| DDLogInfo("AttachmentDownloader: batch download remote\(location == .remoteMissing ? "ly missing" : "") file \(attachment.key)") | |
| DDLogInfo("AttachmentDownloader: batch download remote file \(attachment.key)") |
michalrentka
force-pushed
the
syncdownload
branch
2 times, most recently
from
476dd78 to
ea7e8f0
Compare
michalrentka
force-pushed
the
syncdownload
branch
from
ea7e8f0 to
e7a7831
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #220