Fix for removed statuses 'refunded', 'charged_back' and 'paidout'#10
Open
Fix for removed statuses 'refunded', 'charged_back' and 'paidout'#10
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adapts the Mollie payment integration to support the v2 API, where statuses 'refunded', 'charged_back', and 'paidout' are no longer directly returned in the status field. Instead, these statuses must be derived from the presence of specific links in the _links object of payment responses.
Key changes:
- Added
payment_status/1function to derive payment status from_linkspresence when necessary - Modified
status_dateto accept status as first parameter for proper date selection based on status - Updated all call sites to compute status via
payment_status/1before passing tostatus_date
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Mollie v2 API the statuses 'refunded', 'charged_back' and 'paidout' are removed.
The final status is now 'paid'. The removed statuses need to be derived from the presence of links in the _links object.