feat: improve test coverage and enforce variable gradient consistency#205
Open
Rakshitha-Ireddi wants to merge 1 commit intozou-group:mainfrom
Open
feat: improve test coverage and enforce variable gradient consistency#205Rakshitha-Ireddi wants to merge 1 commit intozou-group:mainfrom
Rakshitha-Ireddi wants to merge 1 commit intozou-group:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the reliability of the get_engine loading mechanism and enforces graph consistency in Variable.
Changes
Variable.requires_gradto a property. The setter now validates that you cannot setrequires_grad=Falseif any predecessors haverequires_grad=True, preventing invalid computation graph states (addressing a TODO in variable.py).Motivation
Authors