Avoid using %#v for errors when %T is more informative

smarterclayton · smarterclayton · commit 435db312e177 · 2019-03-21T22:54:06.000-04:00
`%#v` may have significant performance costs in frequently invoked code.
diff --git a/staging/src/k8s.io/client-go/tools/cache/shared_informer.go b/staging/src/k8s.io/client-go/tools/cache/shared_informer.go
@@ -555,7 +555,7 @@ func (p *processorListener) run() {
 				case deleteNotification:
 					p.handler.OnDelete(notification.oldObj)
 				default:
-					utilruntime.HandleError(fmt.Errorf("unrecognized notification: %#v", next))
+					utilruntime.HandleError(fmt.Errorf("unrecognized notification: %T", next))
 				}
 			}
 			// the only way to get here is if the p.nextCh is empty and closed

Original file line number	Diff line number	Diff line change
`@@ -555,7 +555,7 @@ func (p *processorListener) run() {`
`555`	`555`	`case deleteNotification:`
`556`	`556`	`p.handler.OnDelete(notification.oldObj)`
`557`	`557`	`default:`
`558`		`- utilruntime.HandleError(fmt.Errorf("unrecognized notification: %#v", next))`
	`558`	`+ utilruntime.HandleError(fmt.Errorf("unrecognized notification: %T", next))`
`559`	`559`	`}`
`560`	`560`	`}`
`561`	`561`	`// the only way to get here is if the p.nextCh is empty and closed`