Merge pull request kubernetes#86598 from zhlhahaha/e2e_kubeadm_1410_2

k8s-ci-robot · web-flow · commit 6b5cf90ecd2f · 2019-12-31T15:43:39.000-08:00
Remove todos for verification of “allowed to post CSR” and "allowed to auto approve CSR" for bootstraptoken group
diff --git a/test/e2e_kubeadm/bootstrap_token_test.go b/test/e2e_kubeadm/bootstrap_token_test.go
@@ -73,7 +73,6 @@ var _ = Describe("bootstrap token", func() {
 			rbacv1.GroupKind, bootstrapTokensGroup,
 			bootstrapTokensAllowPostCSRClusterRoleName,
 		)
-		//TODO: check if possible to verify "allowed to post CSR" using subject asses review as well
 	})
 
 	ginkgo.It("should be allowed to auto approve CSR for kubelet certificates on joining nodes", func() {
@@ -82,6 +81,5 @@ var _ = Describe("bootstrap token", func() {
 			rbacv1.GroupKind, bootstrapTokensGroup,
 			bootstrapTokensCSRAutoApprovalClusterRoleName,
 		)
-		//TODO: check if possible to verify "allowed to auto approve CSR" using subject asses review as well
 	})
 })

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,6 @@ var _ = Describe("bootstrap token", func() {`
`73`	`73`	`rbacv1.GroupKind, bootstrapTokensGroup,`
`74`	`74`	`bootstrapTokensAllowPostCSRClusterRoleName,`
`75`	`75`	`)`
`76`		`- //TODO: check if possible to verify "allowed to post CSR" using subject asses review as well`
`77`	`76`	`})`
`78`	`77`
`79`	`78`	`ginkgo.It("should be allowed to auto approve CSR for kubelet certificates on joining nodes", func() {`
`@@ -82,6 +81,5 @@ var _ = Describe("bootstrap token", func() {`
`82`	`81`	`rbacv1.GroupKind, bootstrapTokensGroup,`
`83`	`82`	`bootstrapTokensCSRAutoApprovalClusterRoleName,`
`84`	`83`	`)`
`85`		`- //TODO: check if possible to verify "allowed to auto approve CSR" using subject asses review as well`
`86`	`84`	`})`
`87`	`85`	`})`