Skip to content

Commit 9ac3fad

Browse files
authored
Merge pull request kubernetes#80126 from aojea/redis
Use docker official redis images
2 parents d900746 + 048f7a2 commit 9ac3fad

File tree

7 files changed

+26
-22
lines changed

7 files changed

+26
-22
lines changed

test/e2e/common/util.go

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -65,17 +65,16 @@ var CommonImageWhiteList = sets.NewString(
6565
)
6666

6767
type testImagesStruct struct {
68-
AgnhostImage string
69-
BusyBoxImage string
70-
GBFrontendImage string
71-
GBRedisSlaveImage string
72-
KittenImage string
73-
MounttestImage string
74-
NautilusImage string
75-
NginxImage string
76-
NginxNewImage string
77-
PauseImage string
78-
RedisImage string
68+
AgnhostImage string
69+
BusyBoxImage string
70+
GBFrontendImage string
71+
KittenImage string
72+
MounttestImage string
73+
NautilusImage string
74+
NginxImage string
75+
NginxNewImage string
76+
PauseImage string
77+
RedisImage string
7978
}
8079

8180
var testImages testImagesStruct
@@ -85,7 +84,6 @@ func init() {
8584
imageutils.GetE2EImage(imageutils.Agnhost),
8685
imageutils.GetE2EImage(imageutils.BusyBox),
8786
imageutils.GetE2EImage(imageutils.GBFrontend),
88-
imageutils.GetE2EImage(imageutils.GBRedisSlave),
8987
imageutils.GetE2EImage(imageutils.Kitten),
9088
imageutils.GetE2EImage(imageutils.Mounttest),
9189
imageutils.GetE2EImage(imageutils.Nautilus),

test/e2e/kubectl/kubectl.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1144,7 +1144,7 @@ metadata:
11441144
waitForOrFailWithDebug(1)
11451145
forEachPod(func(pod v1.Pod) {
11461146
e2elog.Logf("wait on redis-master startup in %v ", ns)
1147-
framework.LookForStringInLog(ns, pod.Name, "redis-master", "The server is now ready to accept connections", framework.PodStartTimeout)
1147+
framework.LookForStringInLog(ns, pod.Name, "redis-master", "Ready to accept connections", framework.PodStartTimeout)
11481148
})
11491149
validateService := func(name string, servicePort int, timeout time.Duration) {
11501150
err := wait.Poll(framework.Poll, timeout, func() (bool, error) {
@@ -1323,7 +1323,7 @@ metadata:
13231323
waitForOrFailWithDebug(1)
13241324
forEachPod(func(pod v1.Pod) {
13251325
ginkgo.By("checking for a matching strings")
1326-
_, err := framework.LookForStringInLog(ns, pod.Name, containerName, "The server is now ready to accept connections", framework.PodStartTimeout)
1326+
_, err := framework.LookForStringInLog(ns, pod.Name, containerName, "Ready to accept connections", framework.PodStartTimeout)
13271327
framework.ExpectNoError(err)
13281328

13291329
ginkgo.By("limiting log lines")

test/e2e/testing-manifests/guestbook/legacy/redis-master-controller.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ spec:
1717
spec:
1818
containers:
1919
- name: master
20-
image: docker.io/library/redis:3.2.9-alpine
20+
image: docker.io/library/redis:5.0.5-alpine
2121
resources:
2222
requests:
2323
cpu: 100m

test/e2e/testing-manifests/guestbook/legacy/redis-slave-controller.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,10 @@ spec:
1717
spec:
1818
containers:
1919
- name: slave
20-
image: gcr.io/google_samples/gb-redisslave:v1
20+
image: docker.io/library/redis:5.0.5-alpine
21+
# We are only implementing the dns option of:
22+
# https://github.com/kubernetes/examples/blob/97c7ed0eb6555a4b667d2877f965d392e00abc45/guestbook/redis-slave/run.sh
23+
command: [ "redis-server", "--slaveof", "redis-master", "6379" ]
2124
resources:
2225
requests:
2326
cpu: 100m

test/e2e/testing-manifests/guestbook/redis-slave-deployment.yaml.in

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,10 @@ spec:
1818
spec:
1919
containers:
2020
- name: slave
21-
image: {{.GBRedisSlaveImage}}
21+
image: {{.RedisImage}}
22+
# We are only implementing the dns option of:
23+
# https://github.com/kubernetes/examples/blob/97c7ed0eb6555a4b667d2877f965d392e00abc45/guestbook/redis-slave/run.sh
24+
command: [ "redis-server", "--slaveof", "redis-master", "6379" ]
2225
resources:
2326
requests:
2427
cpu: 100m

test/fixtures/doc-yaml/user-guide/replicaset/redis-slave.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,10 @@ spec:
2424
spec:
2525
containers:
2626
- name: slave
27-
image: gcr.io/google-samples/gb-redisslave:v3
27+
image: docker.io/library/redis:5.0.5-alpine
28+
# We are only implementing the dns option of:
29+
# https://github.com/kubernetes/examples/blob/97c7ed0eb6555a4b667d2877f965d392e00abc45/guestbook/redis-slave/run.sh
30+
command: [ "redis-server", "--slaveof", "redis-master", "6379" ]
2831
resources:
2932
requests:
3033
cpu: 100m

test/utils/image/manifest.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,6 @@ const (
134134
Etcd
135135
// GBFrontend image
136136
GBFrontend
137-
// GBRedisSlave image
138-
GBRedisSlave
139137
// Httpd image
140138
Httpd
141139
// HttpdNew image
@@ -214,7 +212,6 @@ func initImageConfigs() map[int]Config {
214212
configs[EchoServer] = Config{e2eRegistry, "echoserver", "2.2"}
215213
configs[Etcd] = Config{gcRegistry, "etcd", "3.3.10"}
216214
configs[GBFrontend] = Config{sampleRegistry, "gb-frontend", "v6"}
217-
configs[GBRedisSlave] = Config{sampleRegistry, "gb-redisslave", "v3"}
218215
configs[Httpd] = Config{dockerLibraryRegistry, "httpd", "2.4.38-alpine"}
219216
configs[HttpdNew] = Config{dockerLibraryRegistry, "httpd", "2.4.39-alpine"}
220217
configs[Invalid] = Config{gcRegistry, "invalid-image", "invalid-tag"}
@@ -234,7 +231,7 @@ func initImageConfigs() map[int]Config {
234231
configs[Perl] = Config{dockerLibraryRegistry, "perl", "5.26"}
235232
configs[PrometheusDummyExporter] = Config{e2eRegistry, "prometheus-dummy-exporter", "v0.1.0"}
236233
configs[PrometheusToSd] = Config{e2eRegistry, "prometheus-to-sd", "v0.5.0"}
237-
configs[Redis] = Config{dockerLibraryRegistry, "redis", "3.2.9-alpine"}
234+
configs[Redis] = Config{dockerLibraryRegistry, "redis", "5.0.5-alpine"}
238235
configs[ResourceConsumer] = Config{e2eRegistry, "resource-consumer", "1.5"}
239236
configs[ResourceController] = Config{e2eRegistry, "resource-consumer-controller", "1.0"}
240237
configs[SdDummyExporter] = Config{gcRegistry, "sd-dummy-exporter", "v0.2.0"}

0 commit comments

Comments
 (0)