Skip to content

Commit cd9519f

Browse files
authored
Merge pull request kubernetes#82004 from pohly/ephemeral-beta
ephemeral inline CSI volumes as beta
2 parents e6b6e40 + 482a900 commit cd9519f

File tree

9 files changed

+8
-9
lines changed

9 files changed

+8
-9
lines changed

api/openapi-spec/swagger.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/features/kube_features.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,6 +329,7 @@ const (
329329

330330
// owner: @vladimirvivien
331331
// alpha: v1.14
332+
// beta: v1.16
332333
//
333334
// Enables CSI Inline volumes support for pods
334335
CSIInlineVolume featuregate.Feature = "CSIInlineVolume"
@@ -549,7 +550,7 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS
549550
VolumeSubpathEnvExpansion: {Default: true, PreRelease: featuregate.Beta},
550551
ResourceQuotaScopeSelectors: {Default: true, PreRelease: featuregate.Beta},
551552
CSIBlockVolume: {Default: true, PreRelease: featuregate.Beta},
552-
CSIInlineVolume: {Default: false, PreRelease: featuregate.Alpha},
553+
CSIInlineVolume: {Default: true, PreRelease: featuregate.Beta},
553554
RuntimeClass: {Default: true, PreRelease: featuregate.Beta},
554555
NodeLease: {Default: true, PreRelease: featuregate.Beta},
555556
SCTPSupport: {Default: false, PreRelease: featuregate.Alpha},

pkg/volume/csi/csi_mounter_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,8 @@ func MounterSetUpTests(t *testing.T, podInfoEnabled bool) {
154154
klog.Infof("Starting test %s", test.name)
155155
// Modes must be set if (and only if) CSIInlineVolume is enabled.
156156
var modes []storagev1beta1.VolumeLifecycleMode
157+
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.CSIInlineVolume, test.csiInlineVolume)()
157158
if test.csiInlineVolume {
158-
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.CSIInlineVolume, true)()
159159
modes = append(modes, storagev1beta1.VolumeLifecyclePersistent)
160160
}
161161
fakeClient := fakeclient.NewSimpleClientset(

pkg/volume/csi/csi_plugin_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,7 @@ func TestPluginGetVolumeNameWithInline(t *testing.T) {
231231

232232
func TestPluginCanSupport(t *testing.T) {
233233
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.CSIBlockVolume, true)()
234+
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.CSIInlineVolume, false)()
234235

235236
tests := []struct {
236237
name string

staging/src/k8s.io/api/extensions/v1beta1/generated.proto

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

staging/src/k8s.io/api/extensions/v1beta1/types.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -930,7 +930,6 @@ type PodSecurityPolicySpec struct {
930930
AllowedFlexVolumes []AllowedFlexVolume `json:"allowedFlexVolumes,omitempty" protobuf:"bytes,18,rep,name=allowedFlexVolumes"`
931931
// AllowedCSIDrivers is a whitelist of inline CSI drivers that must be explicitly set to be embedded within a pod spec.
932932
// An empty value indicates that any CSI driver can be used for inline ephemeral volumes.
933-
// This is an alpha field, and is only honored if the API server enables the CSIInlineVolume feature gate.
934933
// +optional
935934
AllowedCSIDrivers []AllowedCSIDriver `json:"allowedCSIDrivers,omitempty" protobuf:"bytes,23,rep,name=allowedCSIDrivers"`
936935
// allowedUnsafeSysctls is a list of explicitly allowed unsafe sysctls, defaults to none.

staging/src/k8s.io/api/extensions/v1beta1/types_swagger_doc_generated.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/e2e/storage/csi_mock_volume.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -322,8 +322,7 @@ var _ = utils.SIGDescribe("CSI mock volume", func() {
322322
expectEphemeral: false,
323323
},
324324
{
325-
// TODO(pohly): remove the feature tag when moving to beta
326-
name: "contain ephemeral=true when using inline volume [Feature:CSIInlineVolume]",
325+
name: "contain ephemeral=true when using inline volume",
327326
podInfoOnMount: &podInfoTrue,
328327
deployClusterRegistrar: true,
329328
expectPodInfo: true,

test/e2e/storage/testsuites/ephemeral.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ var _ TestSuite = &ephemeralTestSuite{}
4545
func InitEphemeralTestSuite() TestSuite {
4646
return &ephemeralTestSuite{
4747
tsInfo: TestSuiteInfo{
48-
name: "ephemeral [Feature:CSIInlineVolume]",
48+
name: "ephemeral",
4949
testPatterns: []testpatterns.TestPattern{
5050
{
5151
Name: "inline ephemeral CSI volume",

0 commit comments

Comments
 (0)